AdBlocker

  • This topic has 29 replies, 9 voices, and was last updated Dec 5-11:03 am by marcelocripe.
Viewing 15 posts - 1 through 15 (of 30 total)
  • Author
    Posts
  • #124951
    Member
    Faybie

      Regrettably, the AdBlocker on Antix22 and 23 version is not working, after several attempts of unchecking a selected option and it says successful, whenever I rechecked that said option, its showing where same as been restore to the default settings, and still the changes haven’t been save. Below is an attached video of what I’ve experience.

      • This topic was modified 3 months ago by Faybie.
      • This topic was modified 3 months ago by Faybie.
      #124965
      Member
      Robin

        When looking into the script code of block-advert.sh it turns out: This is completely normal behavior, since the state of the checkboxes on startup are not read from the content of current /etc/hosts file, but hard coded within the script. They will always be the same, whatever you have actually blocked or unblocked.

        Nevertheless the script does what it says, it modifies the hosts file to meet the status of the checkboxes of the GUI if you give your OK.

        Technically spoken it clears on each run the hosts file completely from all adblock entries present from a previous run, and adds then again the respective set or sets you’ve selected for blocking. The entries get downloaded freshly always, and only the very sets you have checked.

        That’s the way it works. And if you want to know whether it actually did not obey what you’ve commanded, you’d need to check and compare the /etc/host file before and after one of your runs. You can easily do this by a file compare tool, e.g. meld (sudo apt-get install meld), just make a copy of the hosts file before running the adblocker tool so you can compare the state before and after.

        As outlined, the state of the checkboxes on startup of the adblock-tool doesn’t give any hint about this. The idea is obviously to give unexperienced users a reasonable set of selections at hand, so he doesn’t need to care for “Ohh… Which boxes should I check here?”

        Some additional “Current State LED’s” would be needed in the script code along with writing and reading some additional markers or flag entries, to craft the script to give a feedback to the user on startup about the current state of blocking set(s) in hosts file resulting from previous runs of the very script. But this kind of feedback is for convenience only, the script works already without that exactly as expected.

        Windows is like a submarine. Open a window and serious problems will start.

        #124971
        Member
        PPC

          Hi, strangely enough, you are the second person, in 2 weeks with a similar complaint.
          Due to the original complaint, the script’s interface was improved a bit AND the warning that shows up every time you run AD Blocker states that the main window always shows the default selection, and not what’s currently selected.
          You can easily manually check what’s blocked by running this command AFTER you run Ad Block for the first time:

          cat /etc/hosts| grep "These kinds of sites are blocked"

          This lists what’s currently being blocked (not counting malware sites)
          Now that I think about this, I should have included the contents of this result on the main window, but I just now thought about this easily solution… but I did not want to add more complexity to the script, trying to add a confirmation to which option should be checked (particularly because I have no idea how to easily detect if the malware sites are being blocked, since the script does not add them to the line the previous command lists…).
          Anyway, the warning that will be displayed in the next version will help people understand the contents of the main window better. The script has been this way for about 10 years, and, as far as I can remember, only 2 people complained about it…
          antiX and it’s scrips is created by people on their free time, so we do what we can, when we can.

          EDIT:

          if this command returns anything, then malware sites are also being blocked:

          cat /etc/hosts| grep "010sec.com"

          EDIT2:
          The new version of the script will be available in future antiX updates. I have no idea when it will be used in the OS that you used to save the video you sent- curiously enough the first person that complained about “AD BLOCK NOT WORKING”, also used MX Linux… that person was told, several times, how this script worked… Now you come along saying about the same thing and even with a video to illustrate it! On one hand, I’m impressed: people with real problems should, sometimes, upload videos to show us exactly what the problem is. In your case, you found no problem at all, just the fact like, unlike what’s usually expected, the main window just shows the default settings everyone should use, NOT what the user has currently chosen.

          P.

          • This reply was modified 3 months ago by PPC.
          • This reply was modified 3 months ago by PPC.
          #124997
          Member
          Tee

            Its not strange so another person has noticed in both versions 22/23 when you make changes it does say successful but when you go back to check the same items remain checked off so it would be nice if it reflected the changes so I would like welcome Faybie to Linux hope you enjoy your experience here…

            #124999
            Member
            Faybie

              @PPC and @ROBIN. Thanks for your follow up reply with instructions, unfortunately as a new linux user I don’t expect you to think I can know and do all what you mentioned. Whenever I unchecked a box it remains checked.@WHITECHOCOLATE thank you, trying to enjoy my experience as best as possible.

              • This reply was modified 2 months, 4 weeks ago by Faybie.
              • This reply was modified 2 months, 4 weeks ago by Faybie.
              #125002
              Member
              PPC

                @Faybie – I’m glad we could help. I know the current version of the script should warn users about that unconventional behavior that the main screen has- that’s why, like I mentioned, the next version will warn users about that particularity. We try to make antiX as easy to use as possible, making simple and efficient GUI’s available for all essential tasks.
                This particular “Ad block” script is very old, and I tried to make it easier to use, specially for newbies and people that don’t understand English, making all entries translatable…
                Making it so only options that are currently selected show up “checked” is a bit of hard work, and I’m not a professional programmer, so I can’t do it right now.
                Note: you don’t have to be a tech wizard to follow my instructions, all that is required is that you know how to copy and past and click menu entries:
                so left click the antiX Menu > left click the “Terminal” icon > Copy the first command that I mentioned > click on the terminal window > On the terminal window’s toolbar left click “Edit”, left click “Paste” and press enter. The command will run and the result will appear. It will be something like:

                # These kinds of sites are blocked : fakenews-gambling-porn

                After using the Terminal, you can close it’s window.

                @White Chocolate – yes, “it would be nice if it reflected the changes”. If you know someone that knows bash scripting, you may ask that person for help improving the script, even more that what I did, and make it available here in the forum, I’m sure anticapitalista would appreciate the help.
                I don’t have any problem with people, specially new to Linux users, not understanding that some times scripts act, like this one, in an unconventional way… I do have a problem with people being explained something, in a clear way, several times, and told exactly what to check for to make sure something is working or not, and see those instructions ignored time and time again, and instead, see multiple posts providing random information that no one asks for, keeping several people busy, trying to make a particular user understand a simple concept.

                P.

                • This reply was modified 2 months, 4 weeks ago by PPC.
                • This reply was modified 2 months, 4 weeks ago by PPC.
                • This reply was modified 2 months, 4 weeks ago by PPC.
                #125003
                Member
                Tee

                  Whatever this response above is why more people leave the Linux community and why Linux does not have more users…

                  #125007
                  Member
                  PPC

                    Completely off topic:

                    this response above is why more people leave the Linux community and why Linux does not have more users…

                    I’m curious about what part of my answer do you think would make drive people away… But I do not wish to further pollute this thread with unrelated posts. I’ll just say this: I never was the kind of people that just tells users to go read the manual (well, I did that once, kind of, pointing to exactly where on the FAQ’s the answer to that particular question was). I always try to help people with even the most basic doubts, within my abilities- I’m not a professional programmer, not part of the antiX development team, not even a moderator of the forum. I wrote countless detailed tutorials and FAQ’s, that I think probably help, in a small part, to make antiX probably one of the best documented Linux Distros ever.
                    In this thread, I simple stated, following your comment, that if someone asks for help here, that person should, at least make an effort to understand the replies that are given, specially if they are “in plain” English, and not some “technobabble”.

                    Since Faybie’s doubt was answered, I won’t be posting anything else on this thread.

                    #125008
                    Member
                    Robin

                      when you make changes it does say successful but when you go back to check the same items remain checked off

                      But you understand what “default preselection” means? This is what this script starts with.

                      It simply doesn’t show or care for the current state at all. For this it wasn’t made. Instead simply does what it is designed for: switch to the state you select with the boxes after giving consent by pressing “OK”. This is what it was made for.

                      so it would be nice if it reflected the changes

                      Yes, sure. It will take some time to add this convenience feature while still keep the default preselection of the boxes…

                      But stating the script doesn’t work is simply wrong.

                      Both of you simply did not check out whether the hosts file was changed or not, as at least @ivorymalejuno-com was advised to proof the claim about the script not working (which was in use flawlessly for more than 10 years already)

                      To put it in the words of a bitten apple: »You’re holding it wrong!« 😉

                      Windows is like a submarine. Open a window and serious problems will start.

                      #125009
                      Member
                      Robin

                        And to be clear about that point: The last sentences about „you, the user did it wrong“ above is a JOKE. Don’t take it seriously. Just kidding around.

                        What actually is true: You could take time and read or ask here in forum e.g. “Why for me the state in the antiX adblocker isn’t reflected on startup?” instead of simply claiming it isn’t working, since it comes up with the very same default preset always.

                        Windows is like a submarine. Open a window and serious problems will start.

                        #125104
                        Member
                        Tee

                          I do remember at some point earlier this year it use to remember the checked settings but I did do a fresh install of antiX in November and of course this is when I noticed this issue. Its not a big deal as I do like ads to be blocked.

                          #125107
                          Member
                          PPC

                            I do remember at some point earlier this year it use to remember the checked settings

                            You remember wrong… unless you (or someone else) edited the code of the script, that can’t happen. You might as well listen to the script playing your national anthem: it can’t happen, unless you program it do to so. It’s programmed to always show the same default checks every time it’s main window is opened.

                            P.

                            • This reply was modified 2 months, 4 weeks ago by PPC.
                            • This reply was modified 2 months, 4 weeks ago by PPC.
                            #125109
                            Member
                            Tee

                              I am not afraid to admit my memory has failed me on this issue and let’s all try to be more civil with each other and more understanding too.

                              • This reply was modified 2 months, 4 weeks ago by Tee.
                              • This reply was modified 2 months, 4 weeks ago by Tee.
                              #125128
                              Member
                              Faybie

                                So I see persons are still going back and forth on this Adblocker trend. I’ve also notice propose fix or solution to the issue, @PPC is there an estimated time frame as to when the issue will be solved?…Appreciate you and team effort in regards to having same resolve.

                                • This reply was modified 2 months, 4 weeks ago by Faybie.
                                #125130
                                Member
                                Robin

                                  is there an estimated time frame as to when the issue will be solved?

                                  Please be aware: The issue is solved already: We found out the script works just as it was designed, and does precisely what it is expected to do.

                                  Another question is, whether or when it’s UI will be redesigned to meet your expectations. Asking a team of volunteer for a time frame when something gets done just to meet your personal flavour, is something I really can’t understand, sorry. It proves pretty heavy claims mindedness on your side. People here are not your personal butlers, sorry.

                                  Btw, have you ever tried to ask e.g. Microsoft to change some specific point in their UI design of a piece of software you don’t like or understand intuitively the way it is designed? Good luck… May be you succeed in case you are a powerful industrial customer, maybe then they will listen.

                                  Nevertheless: We do listen.

                                  So it will be changed sooner or later.

                                  But please, don’t ask for a time table for something which is not a security issue. The team of volunteer letting all this happen does it’s very best. If you want to have it done in a specific time frame, I fear you have to do it yourselves (Feel yourselves encouraged to learn how to modify a simple bash script like that). Or just wait until somebody took his spare time to do it. That’s the way Linux runs.

                                  Windows is like a submarine. Open a window and serious problems will start.

                                Viewing 15 posts - 1 through 15 (of 30 total)
                                • You must be logged in to reply to this topic.